Fix #523 Incorrect PHP reflection type for Memcached::cas $cas_token

php-memcached-dev · Nov 16, 2022 · 1214731 · 1214731
1 parent aa4868d
commit 1214731
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/php_memcached.stub.php b/php_memcached.stub.php
@@ -31,8 +31,8 @@ public function touchByKey(string $server_key, string $key, int $expiration=0):
 	public function setMulti(array $items, int $expiration=0): bool {}
 	public function setMultiByKey(string $server_key, array $items, int $expiration=0): bool {}
 
-	public function cas(string $cas_token, string $key, mixed $value, int $expiration=0): bool {}
-	public function casByKey(string $cas_token, string $server_key, string $key, mixed $value, int $expiration=0): bool {}
+	public function cas(string|int|float $cas_token, string $key, mixed $value, int $expiration=0): bool {}
+	public function casByKey(string|int|float $cas_token, string $server_key, string $key, mixed $value, int $expiration=0): bool {}
 	public function add(string $key, mixed $value, int $expiration=0): bool {}
 	public function addByKey(string $server_key, string $key, mixed $value, int $expiration=0): bool {}
 	public function append(string $key, string $value): ?bool {}

diff --git a/php_memcached_arginfo.h b/php_memcached_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 8cb8a18e8e09c6bfc62a51fc31d60171038500ef */
+ * Stub hash: 75604abd7f58655a9ebda6f0ea579840311c1f08 */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Memcached___construct, 0, 0, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, persistent_id, IS_STRING, 1, "null")
@@ -91,14 +91,14 @@ ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_Memcached_setMultiByKey, 0
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_Memcached_cas, 0, 3, _IS_BOOL, 0)
-	ZEND_ARG_TYPE_INFO(0, cas_token, IS_STRING, 0)
+	ZEND_ARG_TYPE_MASK(0, cas_token, MAY_BE_STRING|MAY_BE_LONG|MAY_BE_DOUBLE, NULL)
 	ZEND_ARG_TYPE_INFO(0, key, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, value, IS_MIXED, 0)
 	ZEND_ARG_TYPE_INFO_WITH_DEFAULT_VALUE(0, expiration, IS_LONG, 0, "0")
 ZEND_END_ARG_INFO()
 
 ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_Memcached_casByKey, 0, 4, _IS_BOOL, 0)
-	ZEND_ARG_TYPE_INFO(0, cas_token, IS_STRING, 0)
+	ZEND_ARG_TYPE_MASK(0, cas_token, MAY_BE_STRING|MAY_BE_LONG|MAY_BE_DOUBLE, NULL)
 	ZEND_ARG_TYPE_INFO(0, server_key, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, key, IS_STRING, 0)
 	ZEND_ARG_TYPE_INFO(0, value, IS_MIXED, 0)

diff --git a/php_memcached_legacy_arginfo.h b/php_memcached_legacy_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 8cb8a18e8e09c6bfc62a51fc31d60171038500ef */
+ * Stub hash: 75604abd7f58655a9ebda6f0ea579840311c1f08 */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Memcached___construct, 0, 0, 0)
 	ZEND_ARG_INFO(0, persistent_id)