Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Feature/smart crop" #533

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Conversation

romainneutron
Copy link
Collaborator

This PR should be discussed. It should probably be placed in a "community library" extension outside imagine

@romainneutron
Copy link
Collaborator Author

romainneutron commented Feb 9, 2017

@VincentClair Please elaborate a bring constructive discussion instead of reacting with "thumbs up" or "thumbs down". It does not bring value, just make me feel bad, which is not a nice feeling when you spend time providing time to others for free (aka opensource).

As I already mentioned in #521 (comment), refusing a contribution is not an attack. It's defining the perimeter definition of what will be maintained and guarantee by Imagine (it's a matter of responsability).

As we want to provide an extensible library, it could be very nice to improve extensibility instead of adding features to the core.

@VincentClair
Copy link

@romainneutron Sorry, I don't want to make you feel bad. And I don't take the revert as an attack.

I fully understand the need to border the perimeter of the library.
My main idea behind this was to get a library that don't just manipulate images, but add value on based functionalities. It's only MHO: for example, personally, in all projets i have made, i don't need a drawing API, but the masking functionality is enough.

Many of my clients asked me for a better crop. I have put some logic in a back-office, so they could crop the image them-self, or add a focus point for a responsive image. But a smart crop is more interesting for me if it could be done natively and simplify UX. And i prefer to install one library than many plugins. As I said, it's only my needs.

@romainneutron romainneutron merged commit 1daff96 into develop Feb 10, 2017
@romainneutron romainneutron deleted the revert-464-feature/smart-crop branch February 10, 2017 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants