Make Imagine more hackable, remove final keywords from classes and functions declaration

[romainneutron]

This solves #162.

After thinking about it, I think we should open the interface so Imagine would be more hackable. I don't think classes should be extended, anyway, if some use case require it, let's give developers the ability to do so.

I propose to do it now as it would solve an issue toward version 1.0

[Richtermeister]

Big 👍 I am just running into this issue because I need to mock Imagine\Imagick\Image via phpspec and can't do so. Opening this up would be great, thank you.

[avalanche123]

You should mock the interface

[avalanche123]

I'm +0 on this change

[Richtermeister]

@avalanche123 I'm referring to the Imagick-specific Image implementation, there does not seem to be an interface for it (unless I'm overlooking something).

[stof]

there is an ImageInterface with the methods of the Image. All drivers have the same methods in their Image implementation

[stof]

IMO, a much better fix would be to provide needed extension points through composition in the library rather than opening for inheritance.
If you look at Behat 3 for instance, we managed to have a fully-extensible library while having final class quite everywhere

[Richtermeister]

@stof This method here: https://github.com/avalanche123/Imagine/blob/develop/lib/Imagine/Imagick/Image.php#L95 is not in the Interface, it is unique to the ImagickImage.

I have a filter which only works on Imagick, not on GD, and I am using this method to access the underlying Imagick instance. This work great, but I cannot test it.

[mlocati]

I'm closing this because too many changes occurred. Let's continue the discussion in #162