Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 8.2 that ksort() deals with int/string keys differently.
https://php.watch/versions/8.2/ksort-SORT_REGULAR-order-changes
Up to PHP 8.1 the int keys are sorted last.
From PHP 8.2 the int keys are sorted first.
The current .mo test file has the original string
12345
in the end.This was ok until PHP 8.2.
This PR makes sure that the strings of the generated
.mo
file are sorted by the original, comparing all keys as strings and outputs the strings with numbers before the ones with letters.Another string is added to the test to make sure that the original
12345
is sorted before15
(compared as strings, as it's supposed)The result of the translations array before output to
.mo
file is:12345
15
Original
Other comment
Fixes #298