Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description is not set when generating files #253

Closed
NathanBnm opened this issue Mar 12, 2020 · 4 comments
Closed

Description is not set when generating files #253

NathanBnm opened this issue Mar 12, 2020 · 4 comments

Comments

@NathanBnm
Copy link
Contributor

I noticed that you didn't added the description to the PO files header in the PO Generator.
Would you mind to add that?
@NathanBnm NathanBnm changed the title Description is not set when generatin files Description is not set when generating files Mar 12, 2020
oscarotero added a commit that referenced this issue Mar 12, 2020
@oscarotero
Added description and flag to generated po files #253
432cf36
@oscarotero
Copy link
Member

Yes, I forgot that. Just commited a change with this. Can you test if it works fine now before release a new tag?

@NathanBnm
Copy link
Contributor Author

@oscarotero this is working fine. Please just add one extra line between the description and the flags lke that: $lines[] = "#";

oscarotero added a commit that referenced this issue Mar 14, 2020
@oscarotero
include a separation line between description and headers #253
f2f6305
@oscarotero
Copy link
Member

Ok, done and released.

@NathanBnm
Copy link
Contributor Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oscarotero @NathanBnm