-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync H1 and H2 Markdown headers #1292
base: master
Are you sure you want to change the base?
Conversation
I think this could be automated with I quickly did a pull request against my fork first to show how it can be done: https://github.com/drupol/fig-standards/pull/1 Let me know what you think all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Well, not all unfortunately. This PR fixes some issues where the indentation level was wrong, and I don't think that can be automated... |
Oh ? Curious to see where you spotted that, can you add a comment where the issue is ? I will try to understand why and maybe provide a better solution. |
@@ -63,7 +63,7 @@ Should you have any questions please contact the secretaries on info [at] php-fi | |||
[dot] org. Failure to comply with guidelines will result in revokation of merge | |||
access. Merge access is a privilege and not a right. | |||
|
|||
# Tagging | |||
## Tagging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the fixes on this file where due to (logical) level errors. This cannot be automated, it's due to the content, not the form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right, i never though this would be the issue, this is actually a cool fix. It does that because there can only be one # title
.
Is this still open because of the discussion around automating it? |
Hello, I was just browsing the PSRs and in the past there were some syncs done on the H1 and H2 Markdown headings. This fixes the rest. Issue is also that some titles are not displayed on the php-fig.org site if the headings don't follow some logic.