Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Render embed templates correctly #67

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Conversation

carbontwelve
Copy link
Contributor

This PR solves #66, by compiling the embeded template before then passing it through to an embed template.

... I expected this to fail, but it seems that shortcodes get ran before the embed is embedded. The bug report can't be reproduced.
@carbontwelve carbontwelve merged commit ee16917 into v1.1.0 Nov 29, 2024
@carbontwelve carbontwelve deleted the patch/v1.1.0/#66 branch November 29, 2024 17:28
@carbontwelve carbontwelve added this to the v1.1.0 milestone Nov 29, 2024
@carbontwelve carbontwelve linked an issue Dec 2, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Embed not rendering template correctly
1 participant