Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: wikilink lookup by alias takes on page title as link text (v1.1.0-rc2) #41

Closed
carbontwelve opened this issue May 3, 2024 · 0 comments · Fixed by #42 · May be fixed by #21
Closed

BUG: wikilink lookup by alias takes on page title as link text (v1.1.0-rc2) #41

carbontwelve opened this issue May 3, 2024 · 0 comments · Fixed by #42 · May be fixed by #21
Labels
bug Something isn't working status:pending-release Issue solved in next version release
Milestone
v1.1.0

Comments

@carbontwelve
Copy link
Contributor

Wikilink lookup by alias works in that it will link to the page, however, it should be using the alias as the link text and not the linked page's title.
@carbontwelve carbontwelve added the bug Something isn't working label May 3, 2024
@carbontwelve carbontwelve added this to the v1.1.0 milestone May 3, 2024
@carbontwelve carbontwelve changed the title BUG: wikilink lookup by alias takes on page title as link text BUG: wikilink lookup by alias takes on page title as link text (v1.1.0-rc2) May 3, 2024
carbontwelve added a commit that referenced this issue May 3, 2024
@carbontwelve
chore: add breaking test for #41
10ea08e
carbontwelve added a commit that referenced this issue May 4, 2024
@carbontwelve
bugfix(#41): use alias as link text if lookup source
f46e8d5
@carbontwelve carbontwelve mentioned this issue May 4, 2024
Merged
carbontwelve added a commit that referenced this issue May 4, 2024
@carbontwelve
doc(#41): update CHANGELOG.md
787a379
carbontwelve added a commit that referenced this issue May 4, 2024
@carbontwelve
Merge pull request #42 from photogabble/patch/v1.1.0/#41
24175a6 
BUGFIX: Use alias as link text if it's the lookup source
@carbontwelve carbontwelve linked a pull request May 4, 2024 that will close this issue
Release 1.1.0 #21
Draft
@carbontwelve carbontwelve added the status:pending-release Issue solved in next version release label May 4, 2024
carbontwelve added a commit that referenced this issue May 4, 2024
@carbontwelve
chore: remove TODO completed by #41
a8d876b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working status:pending-release Issue solved in next version release
Projects
None yet
Milestone
v1.1.0
1 participant
@carbontwelve