Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor channel object #73

Open
photofroggy opened this issue Mar 30, 2013 · 3 comments
Open

Refactor channel object #73

photofroggy opened this issue Mar 30, 2013 · 3 comments
Assignees
@photofroggy
Labels
enhancement ui wip

Comments

@photofroggy
Copy link
Owner

It is horrible at the moment. Needs some work.
@ghost ghost assigned photofroggy Mar 30, 2013
@photofroggy
Copy link
Owner Author

Stopped storing jQuery objects for title and topic, for the most part.

Should mean less objects in memory at any one time.

photofroggy pushed a commit that referenced this issue Apr 1, 2013
bump. cleanup. bug fixes. removing header data storage from channel u…
952cb96 
…i object. re issue #73
photofroggy pushed a commit that referenced this issue Apr 19, 2013
clean up. bug fix. highlighting now works properly. made ui capable o…
b09f932 
…f handling events from the server. need to make it actually do UI stuff for each event this way rather than having the client invoke it. #77 #73.
@photofroggy
Copy link
Owner Author

Need to remove references to the UI from the client's channel object.

Trying to get the UI to be more like a plugin.

photofroggy pushed a commit that referenced this issue Apr 19, 2013
clean up. moved code from client to ui. client no longer creates and …
7c3fbd5 
…destroys ui channels directly. ui lib hooks events and does everything regarding adding and removing. need to move other ui functions to the ui lib in the same way. #73.
photofroggy pushed a commit that referenced this issue Apr 19, 2013
got rid of the clear method from client channel objects. need to move…
20ebebf 
… commands relating to the UI to the UI lib. maybe. #73.
photofroggy pushed a commit that referenced this issue Apr 19, 2013
removing seemingly pointless methods. #73.
ff586d9
photofroggy pushed a commit that referenced this issue Apr 21, 2013
bug fix. pchat user list displays properly again. changes in flow bro…
92af50d 
…ke this. #73.
photofroggy pushed a commit that referenced this issue Apr 21, 2013
clean up. making pc build happen through events. direct refence to ui…
543fd94 
… in pc building method removed. #73.
photofroggy pushed a commit that referenced this issue Apr 21, 2013
clean up. removed reference to ui from set_header. ui channel objects…
1e423e8 
… handling property packets. need to do stuff for other properties. improve the flow. title and topic now set through events. #73.
photofroggy pushed a commit that referenced this issue Apr 21, 2013
using different events to hook in privclasses. #73.
24ebdaa
photofroggy pushed a commit that referenced this issue Apr 21, 2013
moved event handling of user list being set. #73.
afff107
photofroggy pushed a commit that referenced this issue Apr 21, 2013
moved event hooks for user list manipulations. #73.
9c24e22
photofroggy pushed a commit that referenced this issue Apr 21, 2013
got rid of some more pointless methods in the channel object. started…
f0b96dd 
… work on moving the title and topic change notices to the ui lib. #73.
photofroggy pushed a commit that referenced this issue Apr 21, 2013
notices for title and topic changes fixed. #73.
84a6c53
photofroggy pushed a commit that referenced this issue Apr 21, 2013
removed ui interactions from the client channel object. wooo. #73.
e7044ad
@photofroggy
Copy link
Owner Author

Headers disappear if join event fails for currently joined channel.

photofroggy pushed a commit that referenced this issue May 5, 2013
bug fix. channel headers no longer cleared on join error. #73
8393f39
photofroggy pushed a commit that referenced this issue May 5, 2013
really in the wrong branch here... base tab stuff now working, wooo. …
a3eb097 
…need to create a base channel template. #73
photofroggy pushed a commit that referenced this issue May 5, 2013
created html template for basetab. #73
d6e0557
photofroggy pushed a commit that referenced this issue May 6, 2013
resizing added to basetab class. added stub loop method to basetab cl…
bb07424 
…ass. #73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@photofroggy photofroggy

Labels
enhancement ui wip
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@photofroggy