chore: add type property under conditional exports in package.json #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I messed with the previous commits, I'll open another PR if you'd prefer. |
rektdeckard
approved these changes
Mar 29, 2024
|
Can't see any conflicts, but unable to rebase and merge. Would you resubmit? |
rektdeckard
added a commit
that referenced
this pull request
Mar 29, 2024
Hey, I see you already pushed this to main, should the PR be closed now? |
|
Yep, sorry to jump the gun on you! Thanks for the fix anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves a tsc problem that occurs when
"module": "nodenext"is set in tsconfig.json (I couldn't figure why exactly). SettingcompilerOptions.pathsalso solves the problem, but I think it would be more convenient if this was changed in the upstream.Without any changes: