Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

App crashes when initialising with topics (v2.0.0-rc1) #1461

Closed
CookieCookson opened this issue Dec 14, 2016 · 2 comments
Closed

App crashes when initialising with topics (v2.0.0-rc1) #1461

CookieCookson opened this issue Dec 14, 2016 · 2 comments

Comments

@CookieCookson
Copy link
Contributor

Expected Behaviour

App should initialise push notifications with the FCM server.

Actual Behaviour

App crashes out to home screen.

Reproduce Scenario (including but not limited to)

?

Steps to Reproduce

  1. Perform window.PushNotification.init() and pass through topics as an array of strings e.g.
window.PushNotification.init({
    ...
    topics: ['test']
...
});

Platform and Version (eg. Android 5.0 or iOS 9.2.1)

iOS 10.2 (Beta 8)

(Android) What device vendor (e.g. Samsung, HTC, Sony...)

Apple

Cordova CLI version and cordova platform version

cordova 6.4.0
cordova-ios 4.3.0

Plugin version

2.0.0-rc1

Sample Push Data Payload

N/A

Sample Code that illustrates the problem

window.PushNotification.init({
    ...
    topics: ['test']
...
});

Logs taken while reproducing problem

19f1db496c063f52367708acab000543.log.txt

@macdonst
Copy link
Member

@CookieCookson it's fixed in the 2.0.x branch now. I believe I screwed up a merge. Thanks for raising the bug.

macdonst added a commit that referenced this issue May 25, 2017
* Added partial Android FCM support (#975)

* Modified plugin.xml to include FCM changes

* Plugin.xml changes for FCM

* Java changes for FCM

* Increased plugin version to 2.0.0

* Increased plugin version in package.json

* Added topic subscription/unsubscription

* Removed some empty lines

* Fixed empty token on android first run (#1008)

* Removed GCM files and added FCM files

* Added .framework files as custom frameworks

* Changed code to work with FCM

* Added hook and resource file to copy GoogleService-Info.plist

* fixed registration and removed unused code

* Use CocoaPods

* Fix rebase errors

* Fix topic subscription and unsubscription on FCM

* Refactor GCMIntentService to FCMService

* Issue #689: Remove sender id from PushNotification init Android options

* Issue #689: Remove sender id from PushNotification init iOS options

* 📝 Update to using fcm-node

* 🐛 Issue #1188: Strings.xml google_app_id conflict with google-services.json

* Add empty google services plist

* Pin FCM to 9.8.0

* 🔧 Add browser platform back for FCM branch

* 🔨🔧⬆️ Use Babel to transpile ES2015 code

* 🔧 add tern to gitignore

* 🔖 Bumping plugin version to 2.0.0-rc1

* 2.0.0-rc1

* Updating CHANGELOG

* Fixing my merge error for PR #1378 Optional event emit instead of function call for action buttons

* 🐛🍎 Issue #1461: App crashes when initialising with topics (v2.0.0-rc1)

* 🐛🐧📝⬆️ #1460: Build Issue Android

* 🐛🍎🔧 Fixing a merge issue where aps-environment was accidentally removed

* 🐧📝🐛 Issue #1470: Cannot install phonegap-plugin-push on master

* 📝 Using a newer version on the examples

* 🍎🐛 Issue #1497: App crashes after refreshing when using FCM (v2)

* Bumping plugin version to 2.0.0-rc2

* 2.0.0-rc2

* Updating CHANGELOG

* Added partial Android FCM support (#975)

* Modified plugin.xml to include FCM changes

* Plugin.xml changes for FCM

* Java changes for FCM

* Increased plugin version to 2.0.0

* Increased plugin version in package.json

* Added topic subscription/unsubscription

* Removed some empty lines

* Removed GCM files and added FCM files

* Changed code to work with FCM

* Added hook and resource file to copy GoogleService-Info.plist

* Use CocoaPods

* Fix rebase errors

* Issue #689: Remove sender id from PushNotification init Android options

* 🐛 Issue #1188: Strings.xml google_app_id conflict with google-services.json

* Pin FCM to 9.8.0

* 🔧 Add browser platform back for FCM branch

* 🔨🔧⬆️ Use Babel to transpile ES2015 code

* 🔧 add tern to gitignore

* 🔖 Bumping plugin version to 2.0.0-rc1

* 🐛🐧📝⬆️ #1460: Build Issue Android

* Bumping plugin version to 2.0.0-rc2

* Added partial Android FCM support (#975)

* Modified plugin.xml to include FCM changes

* Plugin.xml changes for FCM

* Java changes for FCM

* Increased plugin version to 2.0.0

* Increased plugin version in package.json

* Added topic subscription/unsubscription

* Removed some empty lines

* Removed GCM files and added FCM files

* Added hook and resource file to copy GoogleService-Info.plist

* Use CocoaPods

* Fix rebase errors

* 🐛 Issue #1188: Strings.xml google_app_id conflict with google-services.json

* Updating CHANGELOG

* ✏️ fixing error in CHANGELOG

* Bumping plugin version to 2.0.0-rc2

* Updating CHANGELOG

* Added partial Android FCM support (#975)

* Modified plugin.xml to include FCM changes

* Plugin.xml changes for FCM

* Java changes for FCM

* Increased plugin version to 2.0.0

* Increased plugin version in package.json

* Added topic subscription/unsubscription

* Removed some empty lines

* Removed GCM files and added FCM files

* Changed code to work with FCM

* Added hook and resource file to copy GoogleService-Info.plist

* fixed registration and removed unused code

* Use CocoaPods

* Fix rebase errors

* Issue #689: Remove sender id from PushNotification init Android options

* Issue #689: Remove sender id from PushNotification init iOS options

* 🐛 Issue #1188: Strings.xml google_app_id conflict with google-services.json

* 🔧 add tern to gitignore

* 🔖 Bumping plugin version to 2.0.0-rc1

* Bumping plugin version to 2.0.0-rc2

* Remove hook and use resource-file tag to copy google services file

* Add resource-file way of copying google services files

* Bump requirements

* 🔧 Update cordovaDependencies

* 🔖 Bumping plugin version to 2.0.0-rc3

* 2.0.0-rc3

* Updating CHANGELOG

* Fixes 'framework not found GoogleToolboxForMac' linker error in 2.0.0-rc3 (#1715)

* Remove unused files (#1732)

* Remove GTM framework. (#1739)
@lock
Copy link

lock bot commented Jun 4, 2018

This thread has been automatically locked.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants