Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Column break points #12

Closed
phoityne opened this issue Feb 25, 2017 · 2 comments
Closed

support Column break points #12

phoityne opened this issue Feb 25, 2017 · 2 comments

Comments

@phoityne
Copy link
Owner

supportting Column break points #14784

ghci supports column option with :break command.

:break [<mod>] <l> [<col>] set a breakpoint at the specified location

@phoityne
Copy link
Owner Author

In locally, done.
shipping with next release.

but vscode seemes like still having some probems.
#21167, #21142
(this issue was fixed. #22249)

on phoityne's test, same issue has occurred.

not sure but, this code might be deleting breakpoints on the same line. distinct bps per line.

src/vs/workbench/parts/debug/common/debugModel.ts
L859 // Remove duplicate breakpoints. This can happen when an adapter updates a line number of a breakpoint
L860 this.breakpoints = distinct(this.breakpoints, bp => bp.uri.toString() + bp.lineNumber);
L861 this._onDidChangeBreakpoints.fire();

@phoityne
Copy link
Owner Author

phoityne commented Apr 6, 2017

vscode is fixed. #23659.

and, phoityne was released.

@phoityne phoityne closed this as completed Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant