Multiple column breakpoints on the same line only sends first to the debugger

[wesrupert]

• VSCode Version: 1.10.2 [commit 8076a19]
• OS Version: Windows 10
  

Steps to Reproduce:

1. Create a sample C# app with multiple code blocks on the same line:
   

2. Set multiple column breakpoints on the line while not debugging
   

3. F5 the app

Results:

Expected: setBreakpoints request has multiple breakpoints on the same line

Actual: setBreakpoints request only has the first breakpoint from that line, causing the remaining ones to disappear once the debugger sends a response

Sample

sample - repro.zip

Debug protocol log from C# debugger:

...Some messages truncated...
-> (C) {"command":"launch","arguments":{"name":".NET Core Launch","type":"coreclr","request":"launch","preLaunchTask":"build","program":"e:\\Share\\Samples\\XPlat\\sample - repro/bin/Debug/netcoreapp1.1/sample - repro.dll","args":[],"cwd":"e:\\Share\\Samples\\XPlat\\sample - repro","logging":{"engineLogging":true}},"type":"request","seq":2}
<- (R) {"seq":4,"type":"response","request_seq":2,"success":true,"command":"launch"}
<- (E) {"seq":5,"type":"event","event":"initialized","body":{}}
-> (C) {"command":"setBreakpoints","arguments":{"source":{"path":"e:\\Share\\Samples\\XPlat\\sample - repro\\Program.cs","name":"Program.cs"},"lines":[37],"breakpoints":[{"line":37,"column":35}],"sourceModified":false},"type":"request","seq":4}
<- (R) {"seq":6,"type":"response","request_seq":4,"success":true,"command":"setBreakpoints","message":"","body":{"breakpoints":[{"id":1,"verified":false,"message":"The breakpoint is pending and will be resolved when debugging starts."}]}}
-> (C) {"command":"setExceptionBreakpoints","arguments":{"filters":["user-unhandled"]},"type":"request","seq":5}
<- (R) {"seq":7,"type":"response","request_seq":5,"success":true,"command":"setExceptionBreakpoints"}
-> (C) {"command":"configurationDone","type":"request","seq":6}
-> (C) {"command":"threads","type":"request","seq":7}
<- (R) {"seq":10,"type":"response","request_seq":6,"success":true,"command":"configurationDone"}
...Some messages truncated...

[wesrupert]

Note: Column breakpoint support for the C# extension is in-progress, so the response will not be the same in the wild. The important part is the setBreakpoint command.

{"command":"setBreakpoints","arguments":{"source":{"path":"...","name":"Program.cs"},
>>>>    "lines":[37],"breakpoints":[{"line":37,"column":35}],
"sourceModified":false},"type":"request","seq":4}

[isidorn]

@wesrupert great catch - we should have caught this in the endgame. It will be available in tomorrow's insiders.
We also recommend all our debug extension writers to use vscode insiders to faster spot bugs and get on fixes earlier.

[weinand]

All column breakpoints are now sent correctly.
However, they are immediately removed from VS Code model (see #23659)