Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pool_count as an example for performance #6014

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

josevalim
Copy link
Member

No description provided.

@chrismccord chrismccord merged commit c9b431f into main Dec 11, 2024
14 checks passed
@chrismccord
Copy link
Member

❤️❤️❤️🐥🔥

@chrismccord chrismccord deleted the jv-pool-count-example branch December 11, 2024 21:22
@rmoorman
Copy link
Contributor

Just saw this issue, which reminded me of the fact that for a while now, I am using the database url query to set the poolsize ?pool_size=6, following the documentation here. Wouldn't it make sense to document this here as well?

@josevalim
Copy link
Member Author

I am not sure if pool_count would work there, if it does, please submit a pull request either adding support for it AND/OR documenting it?

@rmoorman
Copy link
Contributor

@josevalim , it does work as documented in the linked ecto documentation page. I will make a new PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants