Make it easier to enable new phoenix_live_reload features #5799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add commented-out JS code to enable in development: 1. Server logs on browser console 2. Browser click to open component on code editor This should make those useful features more discoverable and easier to enable for new apps. Code is based on: https://github.com/phoenixframework/phoenix_live_reload?tab=readme-ov-file#streaming-serving-logs-to-the-web-console https://github.com/phoenixframework/phoenix_live_reload?tab=readme-ov-file#jumping-to-heex-function-definitions See also: https://fly.io/phoenix-files/phoenix-dev-blog-server-logs-in-the-browser-console/
rhcarvalho
force-pushed
the
server-logs-in-new-apps
branch
from
0379740 to
1fd6bd1
Compare
|
Rebased on top of latest main, no changes. |
Gazler
approved these changes
Jul 9, 2024
SteffenDE
added a commit
that referenced
this pull request
Nov 26, 2024
|
Thank you! 🙌 |
SteffenDE
added a commit
that referenced
this pull request
Nov 26, 2024
Relates to: #5799 Relates to: #5910 Co-authored-by: Rodolfo Carvalho <[email protected]> Co-authored-by: ponychicken <[email protected]>
SteffenDE
added a commit
that referenced
this pull request
Nov 27, 2024
Relates to: #5799 Relates to: #5910 Co-authored-by: Rodolfo Carvalho <[email protected]> Co-authored-by: ponychicken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add commented-out JS code to enable in development:
This should make those useful features more discoverable and easier to enable for new apps.
Code is based on:
See also:
https://fly.io/phoenix-files/phoenix-dev-blog-server-logs-in-the-browser-console/