-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plug Updates #38
Plug Updates #38
Conversation
Latest version of plug breaks routing/dispatching. The plug adapters are expecting just a conn returned, no {:ok, conn}. Plus, the router (which is acting as a plug) needs to have init/1 defined for initialization of the options.
@slogsdon Change |
@ericmj I'll update the mix file here shortly. I had forgotten about it because of the latest version of plug requiring |
Updated to reflect the Elxiir v012.4-dev requirement of Plug. Thanks for catching that, @ericmj. |
Thanks @slogsdon . I need to pull this down and tweak the dispatch/controller code since it is still returning {:ok, conn}, i.e. when there's an error in the Controller. This is nice start though. |
@chrismccord No problem. I thought I had caught all of the instances where |
Please go ahead with the changes! |
corrects tests as well. not sure why i didn't do this in the first place
Pushed a fix to properly match on errors @chrismccord. Tests have been updated as well (sorry about not doing this in the first place) and are green. |
Thank you! |
No problem! |
fixes #36.
Latest version of plug breaks routing/dispatching. The plug adapters are expecting just a
conn
returned, no{:ok, conn}
. Plus, the router (which is acting as a plug) needs to haveinit/1
defined for initialization of the options.Also updates the deprecated
//
to\\
to remove compile warning messages.