-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
psh: enable test execution in new psh for imxrt117x #357
Conversation
Unit Test Results7 699 tests - 1 6 984 ✅ - 1 39m 19s ⏱️ +34s Results for commit a903b8a. ± Comparison against base commit 3a22101. This pull request removes 1 test.
♻️ This comment has been updated with latest results. |
045a615
to
19f4d65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an info in commit description that it's done due to resolving #866 issue (someone when looking through commit history can think that it's some new feature)
19f4d65
to
7e1cf71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a part of resolving issue - the issue has been already resolved and that's why we want to enable back this utility in tests
7e1cf71
to
83a2d0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is enable due to resolved of the issue
- that's not gramatically correct, it should be rather:
It is enabled due to the following issue resolution: ...
83a2d0a
to
0e8a248
Compare
17e7992
to
78defb1
Compare
78defb1
to
3cb911a
Compare
3cb911a
to
8b6aaaf
Compare
6067c4a
to
8b6aaaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested that on current changes it works stable?
It is enabled due to the following issue resolution: phoenix-rtos/phoenix-rtos-project#866 JIRA: CI-461
It is enabled due to the following issue resolution: phoenix-rtos/phoenix-rtos-project#580 JIRA: CI-461
70dd0b2
to
ad846fa
Compare
So the issue, reported in phoenix-rtos/phoenix-rtos-project#1103, still exists. To run the tests with changes, we can either disable the test or possibly try running it first. I tested with a reboot before the test, but the issue still occurs. |
ad846fa
to
b6a16c0
Compare
Added due to issue phoenix-rtos/phoenix-rtos-project#1097 JIRA: CI-461
b6a16c0
to
a903b8a
Compare
JIRA: CI-461
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment