-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
armv7m4: add stlink host reset #337
base: master
Are you sure you want to change the base?
Conversation
1ed80b0
to
9b79739
Compare
Unit Test Results7 218 tests - 242 6 527 ✅ - 217 36m 43s ⏱️ - 1m 57s For more details on these failures, see this check. Results for commit fb0aa8f. ± Comparison against base commit 04b1486. This pull request removes 246 and adds 4 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
trunner/target/armv7m4.py
Outdated
stdout=subprocess.PIPE, | ||
stderr=subprocess.STDOUT, | ||
timeout=20, | ||
cwd=os.getcwd(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't use the os module, since TargetBase
should have specific paths to certain locations created (for example self.project_dir
).
Also, I'm thinking if we should check if the reset was successful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First part is done.
Sadly, second one is not possible, OpenOCD throw non-zero status even if MCU voltage reading is below 3.3v (In our projects this reading is not even used and causing non-zero status return)
# TODO add text mode | ||
# NOTE: changing boot modes not needed/supported for this target | ||
pass | ||
def _reboot_dut_text(self, hard): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to our last meeting it will be better to add another method, for example called _reboot_dut_command
, because as you can see sending a reset command to onboard debugger is definitely not a text mode.
def _reboot_dut_text(self, hard): | |
def _reboot_dut_command(self, hard): |
Then we should introduce a launch_context, where we could specify what reset do we want to use. For now we can just change it temporary this way if needed:
9b79739
to
14151d9
Compare
JIRA: CI-433
d2307c4
to
e575aa6
Compare
JIRA: CI-433
e575aa6
to
fb0aa8f
Compare
JIRA: CI-433
Description
Implemented soft reset for host environment to run test runner without using GPIO's.
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment
trunner: wait for possible plo interruption #336