Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hal/imxrt117x: fix IOpad #618

Merged
merged 1 commit into from
Nov 6, 2024
Merged

hal/imxrt117x: fix IOpad #618

merged 1 commit into from
Nov 6, 2024

Conversation

julianuziemblo
Copy link
Contributor

@julianuziemblo julianuziemblo commented Nov 5, 2024 •
edited
Loading

Description

  • properly set ranges of registers configured differently
  • add a way of setting ODE field in non-LPSR/SNVS GPIO registers
  • set proper ranges for setting ODE field in LPSR, SNVS, and remaining GPIO registers

Motivation and Context

related: phoenix-rtos/plo#367

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: armv7m7-imxrt1170-evk.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@julianuziemblo julianuziemblo mentioned this pull request Nov 5, 2024
Merged
14 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024 •
edited
Loading

Unit Test Results

7 949 tests  ±0   7 231 ✅ ±0   42m 11s ⏱️ +17s
  461 suites ±0     718 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit c3912ab. ± Comparison against base commit 91c9cad.

♻️ This comment has been updated with latest results.

@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt117x-evkb branch from b9d3ae3 to 495db72 Compare November 5, 2024 15:52
@julianuziemblo
hal/imxrt117x: fix IOpad
c3912ab 
- properly set ranges of registers configured differently
- add a way of setting ODE field in non-LPSR/SNVS GPIO registers
- set proper ranges for setting ODE field in LPSR, SNVS, and remaining GPIO registers

JIRA: RTOS-963
@julianuziemblo julianuziemblo force-pushed the julianuziemblo/enet-imxrt117x-evkb branch from 495db72 to c3912ab Compare November 5, 2024 16:18
@julianuziemblo julianuziemblo merged commit ee36cbb into master Nov 6, 2024
36 checks passed
@julianuziemblo julianuziemblo deleted the julianuziemblo/enet-imxrt117x-evkb branch November 6, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski approved these changes

@Darchiv Darchiv Awaiting requested review from Darchiv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianuziemblo @agkaminski