Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal/ia32: fix edx restoration in exceptions #612

Closed
wants to merge 1 commit into from

Conversation

badochov
Copy link
Contributor

@badochov badochov commented Oct 25, 2024

JIRA: RTOS-954

Description

Fix of error introduced in #609.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: ia32

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@badochov
Copy link
Contributor Author

I found this using shared libs on C++. There there's a combination of first FPU usage causing exc7 followed by an operation using %edx.

It would be nice to have some tests testing if syscalls only alter the %eax or equivalent in other architectures and exceptions do not alter any register (unless on some arch they are supposed to).

Copy link

Unit Test Results

7 787 tests  ±0   7 069 ✅ ±0   40m 56s ⏱️ -10s
  461 suites ±0     718 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 8f37dbd. ± Comparison against base commit a6de825.

@badochov
Copy link
Contributor Author

Closed as merged in !613

@badochov badochov closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant