map: fix mprotected pages not being copied #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA: RTOS-374
_map_force may return a value above 0 on error, when prot mismatch is encountered. JIRA: RTOS-953
14 tasks
|
DRAFTING: as demo showed issue on ia32, weird that only on one platform there's an issue with this change |
badochov
force-pushed
the
badochov/mprotect-fakeshare
branch
from
00b9289
to
59afb80
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
When a memory region with prot read-write got changed to read, then the memory would not be copied on fork. This result in child and parent sharing this page that can be changed back to being writeable. JIRA: RTOS-953
badochov
force-pushed
the
badochov/mprotect-fakeshare
branch
from
59afb80
to
2319a7a
Compare
Resolved, exception on ia32 were messed up, however, they should not occur as ia32 is non lazy system. |
agkaminski
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: RTOS-953
Description
When a memory region with prot read-write got changed to read, then the
memory would not be copied on fork. This result in child and parent
sharing this page that can be changed back to being writeable.
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment