meterfs: Implement mount, getAttr, setAttr, stat and readdir #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kemonats
reviewed
Jan 11, 2024
| if (name[i] == '/') | ||
| return -ENOENT; | ||
| char *end = strchrnul(name + len, '/'); | ||
| const size_t size = end - name + len; |
There was a problem hiding this comment.
Probably should be:
Suggested change
| const size_t size = end - name + len; | |
| const size_t size = end - (name + len); |
kemonats
reviewed
Jan 11, 2024
| } | ||
|
|
||
| /* Hack-ish - handle virtual "." and ".." */ | ||
| if (offs == 0) { /* "."" */ |
There was a problem hiding this comment.
Suggested change
| if (offs == 0) { /* "."" */ | |
| if (offs == 0) { /* "." */ |
same in line 1476
kemonats
reviewed
Jan 11, 2024
| dent->d_reclen = len; | ||
| dent->d_namlen = len; | ||
| dent->d_type = DT_REG; | ||
| strncpy(dent->d_name, f->header.name, len); |
There was a problem hiding this comment.
it should be faster
Suggested change
| strncpy(dent->d_name, f->header.name, len); | |
| memcpy(dent->d_name, f->header.name, len); |
kemonats
reviewed
Jan 11, 2024
| if (parent == NULL) { | ||
| return -ENOMEM; | ||
| } | ||
| memcpy(parent, ctx->mountpoint, mntlen + 1); |
There was a problem hiding this comment.
a little faster
Suggested change
| memcpy(parent, ctx->mountpoint, mntlen + 1); | |
| memcpy(parent, ctx->mountpoint, mntlen); |
kemonats
reviewed
Jan 12, 2024
| int meterfs_init(meterfs_ctx_t *ctx) | ||
| { | ||
| int err; | ||
| ctx->mountpoint = NULL; |
There was a problem hiding this comment.
Move it after checking the condition ctx == NULL
anglov
requested changes
Jan 23, 2024
There was a problem hiding this comment.
Not reviewied code, I just playing with it a little with adapted flashsrv for DEND project.
My findings below:
1.meterfs: Filesystem check done. Found 23 files.,but ls show 24 files. One file is doubled
2. echo "abc" > /meterfs_mount_point/mfs_file causes that psh destroys file in unexpected way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: RTOS-182
Description
Change is intended as non-breaking, old API should be still functional
Motivation and Context
Allow meterfs to be mounted in a directory and make 'ls' work
Types of changes
How Has This Been Tested?
Checklist:
Special treatment