Updates MSBuild references #282
Conversation
|
This does not work when you just update these dependencies yourself in your own project? |
|
Setting up a project, referencig Buildalyzer and updating those references locally does allow Buildalyzer to build projects with C# 12 features. But I'm not using Buildalyzer directly, I'm using https://github.com/eNeRGy164/LivingDocumentation, which is a dotnet command line tool, to analyze my projects but I'm unable to do so beacuse the referenced and the latest version of Buildalyzer can't build them. |
|
@REscobar Thank you very much for contributing, I intend to evaluate your PR this week, I need to understand if we really won't have a backwards compatibility problem, there are some situations that are not possible to simulate in unit tests. @Corniel do you see any problem? I appreciate your opinion. |
|
If we take a look at: Roslyn's release notes, we can conclude that v We have no paying customers (as far as I know) that would have issues with old systems relying on this older version that can not update. So, I think we should do it. That being said: I think we should define a strategy on how to deal with this dependencies: Should we always aim to go for the latest stable version out there? |
| @@ -19,8 +19,8 @@ ToBeReleased | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.4.0" /> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.VisualBasic.Workspaces" Version="4.4.0" /> | |||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="4.10.0" /> | |||
There was a problem hiding this comment.
Did you try this one ([4,)) too? Did this work as well?
There was a problem hiding this comment.
It does not work with [4,), version 4.0.1 gets installed and fails to build a project with C#12 features
Fixes #281
🚀 Pull Request Template
Description
This PR updates MSbuild references to support C# 12 features which are not buildable using latest public version of Buildalyzer
A test case was added which would fail withouth this commit