Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for azure function #280

Merged
merged 4 commits into from
Sep 8, 2024
Merged

Conversation

dupdob
Copy link
Contributor

@dupdob dupdob commented Jul 16, 2024

Description

This PR adds support for AzureFunctionProject

A simple integration test project is provided as well.

The logic change is: buildalyzer now keeps the first compilation step, disregarding its origin or the last compilation step when triggred by the main project file.
AzureFunction project triggers a compilation step from a temporary subproject to generate a dummy assembly (which purposes has not been identified) and which should not be reported.

Copy link
Contributor

@Corniel Corniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the example project would benefit from some more descriptive/representative naming.

@dupdob
Copy link
Contributor Author

dupdob commented Jul 16, 2024

I think the example project would benefit from some more descriptive/representative naming.

like what? It is an AzureFunction project. I mean: what info is missing?

@phmonte
Copy link
Owner

phmonte commented Jul 31, 2024

@dupdob Thank you for contributing, we are evaluating the PR, I saw that it is related to a Stryker issue, we will try to finalize it as quickly as possible.

@phmonte phmonte requested a review from Corniel July 31, 2024 18:19
{
public class TestFunction
{
[FunctionName("Function1")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[FunctionName("Function1")]
[FunctionName(nameof(TestFunction))]

Copy link
Contributor

@Corniel Corniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the example project.

Copy link
Contributor

@Corniel Corniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@phmonte phmonte merged commit 91ce0b4 into phmonte:main Sep 8, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants