Drop BuildEventArgsReaderProxy
#258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daveaglick Can you confirm this, or explain why it still has purpose? |
|
Interesting - it looks like I added it to provide access to some private stuff via reflection, but then I can't figure out where it was ever used from when looking through the commit history, let alone now. Wonder if I added it trying to work through something and then found another way but forgot to delete it. Regardless, it doesn't look like the kind of thing that's intended to get picked up by some sort of reflection-based class discovery, so I think you're okay deleting it if there are no references. |
|
@daveaglick If you also can not think of any reason to keep this code, let just remove it. |
Merged
|
@phmonte I think it is safe to merge this one too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is internal and seems not to be used at all. Unless, I'm mistaken, this is dead code.