Fix for finding the default SDK in some scenarios #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to find the default SDK and there isn't a global.json the default SDK finder sometimes throw a ArgumentOutOfRange exception because the line breaks between sections in the output from --info is missing. This commit fixes one of those scenarios while keeping the original way of finding the SDK intact.
|
Whoopsie. Failing tests. Didn't see a test project but I'll make sure they pass. |
|
Don’t spend too much time on the tests if it doesn’t look like something introduced from your change - the integration test suite can be flaky. I’ll take a closer look soon. |
|
Thanks, and sorry for the delay merging this in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to find the default SDK and there isn't a global.json the default SDK finder sometimes throw a ArgumentOutOfRange exception because the line breaks between sections in the output from
dotnet --infois missing for some reason.This commit fixes one of those scenarios while keeping the original way of finding the SDK intact.