Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhlyTest namespace in autoload-dev #11

Merged
merged 1 commit into from
Oct 13, 2014
Merged

Conversation

joksnet
Copy link
Contributor

@joksnet joksnet commented Oct 11, 2014

Hello. I want to include this project in my list of lightweight libraries, but it has something that I find problematic to calculate the "weight" of this projects.

The test namespace is included in the autoload configuration, always. See, I use the directories in the autoload configuration of composer to know which are the source folders to parse and calculate the "weight".

Since I think the test namespace will be only used when the dev requirements have been installed it seems like a plausible change.

Hello. I want to include this project in [my list of lightweight libraries](https://github.com/jm42/lightweight-php), but it has something that I find problematic to calculate the "weight" of this projects.

The test namespace is included in the autoload configuration, always. See, I use the directories in the autoload configuration of composer to know which are the *source* folders to parse and calculate the "weight".

Since I think the test namespace will be only used when the dev requirements have been installed it seems like a plausible change.
@weierophinney weierophinney merged commit 254a454 into phly:master Oct 13, 2014
weierophinney added a commit that referenced this pull request Oct 13, 2014
PhlyTest namespace in autoload-dev
weierophinney added a commit that referenced this pull request Oct 13, 2014
weierophinney added a commit that referenced this pull request Oct 13, 2014
weierophinney added a commit to phly/conduit that referenced this pull request Oct 13, 2014
- Per phly/http#11 -- test namespace only needs autoload rules in development.
@joksnet joksnet deleted the patch-1 branch October 14, 2014 03:58
mtymek pushed a commit to mtymek/http that referenced this pull request May 22, 2015
PhlyTest namespace in autoload-dev
mtymek pushed a commit to mtymek/http that referenced this pull request May 22, 2015
mtymek pushed a commit to mtymek/http that referenced this pull request May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants