Allow Phlex::Turbo::Stream
element to take arbitrary attributes
#341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Introduction of Custom Turbo Stream Actions it's not mandatory to always just pass the
action
andtarget
attributes on the<turbo-stream>
element.Since you can write actions which don't target any elements you also don't need to specify the
target
ortargets
attribute (right now with Phlex0.5
you also wouldn't be able to pass over atargets
attribute).Additionally, you need to be able to pass any attribute to the
<turbo-stream>
element so you can use custom attributes in your custom action.For more context: hotwired/turbo-rails#375 and hotwired/turbo-rails#373