-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove runtime dependencies #118
Conversation
@melody-universe this looks very promising :) I would prefer to merge this PR. As I understand it correctly, the other 2 PRs from you are obsolete if we merge this PR? |
You are correct, the other PR's would be obsolete if we merge this PR. I haven't tested all use cases, but I'll build some tests real quick to make sure! |
Just an update on this: I'm working on an automated end-to-end test suite to confirm 100% compatibility between the updated JavaScript action and the current Docker action. While the suite is expensive in terms of runtime, my hope is that it can be used for future pull requests to verify compatibility. You can see the pull request as is working in my fork here. It's automating commits to a test repo I've created here. Still working on building the tests for the rest of the functionality, and right now this is testing the current version of gh-action-bump-version, but once it's done I'll merge it into the JavaScript action and hopefully we should remain at 100% passing! At some point it might be worth considering building an integration test that proxies environment variable access as well as the |
Hey can we please merge this!!! This no longer works as it is outside the npm minor version |
I meant to say.. Your entire github action no longer works as of this morning... |
@melody-universe whats the status on this? |
@joelcoxokc you can set your node version in your own action.yml. |
Thanks @phips28 for the speedy reply and fix |
@phips28 Been busy with day job / life stuff. Working on getting the end-to-end testing suite up right now. I'm imagining we want to push that first and then see the test suite execute against this PR without any changes, since the end-to-end functionality should remain exactly the same. |
This PR removes all runtime dependencies from the library. This allows us to execute the node script without needing a Docker image,
node_modules
, or a bundled asset. This was the final (probably) effort resulting from a suggestion on #42.See a working example of this PR here.