Find without html tree for the remaining combinators #545
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the remaining combinator match types in traverse_html_tuples.
To avoid making this a lot more complex on child and adjacent sibling, this optimized traversal will happen only if these combinators are the last combinator in the selector. Without this limitation we'd need to keep track of a lot of information to not duplicate nodes in the response.
This also adds a small documentation to
traverse_html_tuples
explaining how we are keeping track of the multiple combinators types.