Skip to content

Commit

Permalink
[Media in GPU Process] Remove requiresTextTrackRepresentation in Remo…
Browse files Browse the repository at this point in the history
…teMediaPlayerState

https://bugs.webkit.org/show_bug.cgi?id=217230

Reviewed by Jer Noble.

A Web process can figure out whether the fullscreen/picture-in-picture subtitle
layer (for text track representation) is required by itself, so it does not need
to get the information from the GPU process.

* WebProcess/GPU/media/RemoteMediaPlayerState.h:
(WebKit::RemoteMediaPlayerState::encode const):
(WebKit::RemoteMediaPlayerState::decode):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@267894 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
[email protected] committed Oct 2, 2020
1 parent b5b1109 commit 037307d
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 9 deletions.
15 changes: 15 additions & 0 deletions Source/WebKit/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
2020-10-02 Peng Liu <[email protected]>

[Media in GPU Process] Remove requiresTextTrackRepresentation in RemoteMediaPlayerState
https://bugs.webkit.org/show_bug.cgi?id=217230

Reviewed by Jer Noble.

A Web process can figure out whether the fullscreen/picture-in-picture subtitle
layer (for text track representation) is required by itself, so it does not need
to get the information from the GPU process.

* WebProcess/GPU/media/RemoteMediaPlayerState.h:
(WebKit::RemoteMediaPlayerState::encode const):
(WebKit::RemoteMediaPlayerState::decode):

2020-10-02 Brian Burg <[email protected]>

[Cocoa] Web Inspector: add an ObjC protocol for extension support
Expand Down
10 changes: 1 addition & 9 deletions Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerState.h
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ struct RemoteMediaPlayerState {
bool wirelessVideoPlaybackDisabled { false };
bool hasSingleSecurityOrigin { false };
bool didPassCORSAccessCheck { false };
bool requiresTextTrackRepresentation { false };

template<class Encoder>
void encode(Encoder& encoder) const
Expand Down Expand Up @@ -100,7 +99,6 @@ struct RemoteMediaPlayerState {
encoder << wirelessVideoPlaybackDisabled;
encoder << hasSingleSecurityOrigin;
encoder << didPassCORSAccessCheck;
encoder << requiresTextTrackRepresentation;
}

template <class Decoder>
Expand Down Expand Up @@ -252,11 +250,6 @@ struct RemoteMediaPlayerState {
if (!didPassCORSAccessCheck)
return WTF::nullopt;

Optional<bool> requiresTextTrackRepresentation;
decoder >> requiresTextTrackRepresentation;
if (!requiresTextTrackRepresentation)
return WTF::nullopt;

return {{
WTFMove(*currentTime),
WTFMove(*duration),
Expand Down Expand Up @@ -287,8 +280,7 @@ struct RemoteMediaPlayerState {
*hasAvailableVideoFrame,
*wirelessVideoPlaybackDisabled,
*hasSingleSecurityOrigin,
*didPassCORSAccessCheck,
*requiresTextTrackRepresentation,
*didPassCORSAccessCheck
}};
}

Expand Down

0 comments on commit 037307d

Please sign in to comment.