Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev branch #3

Closed
wants to merge 38 commits into from
Closed

Dev branch #3

wants to merge 38 commits into from

Conversation

philliphall
Copy link
Owner

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Updated the _NUM layer to use top row numbers rather than the num pad - because I have no need for NUM lock and the alternate uses of the num pad. Now I have the option of learning to use symbols by shifting in my _NUM layer and moving to another build one day without a number row. Maybe.
Really annoying to have that many files and folders to sift through. Don't need them in my fork.
Several iterations on my keymap. Will probably just focus on "current" from here out, maybe another dated version if I do something drastic.
Added --update option to json2c - allows you to update only the keymaps array definition in an existing keymap.c, so you don't have to copy/paste all the layer name enums, oled features, etc. every time you just want to change a key.

Tested only in QMK MSYS.
Added comments to json2c after adding the --update feature, in preparation for a pull request.
Splits aren't recognizing each other... not sure why.
Updated encoder and keymap.
Keymap shift and backspace sharing a key became obnoxious. Too hard to reliably and quickly transition between backspace and a shifted key. So I made that key dedicated to shift.

And for backspace, I now use counterclockwise rotation of the left encoder. If I turn it right first, it still does super alt tab. Pretty nice balance I say.

And to take it one step further, if I use counterclockwise/backspace first, I applied the same principle as super-alt-tab to make clockwise rotation within the timer window function as undo :-)
Mostly just moved custom up a level. Also moved more config into info.json from config.h.
Minor keymap tweak as I test mouse buttons, cleaned up some unused macros too.
…nfig.h

	modified:   keyboards/handwired/dactyl_manuform/phil_rev2_blackpill/keymaps/main/keymap.c
	modified:   keyboards/handwired/dactyl_manuform/phil_rev2_blackpill/mcuconf.h
	modified:   keyboards/handwired/dactyl_manuform/phil_rev2_blackpill/rules.mk
Copy link

github-actions bot commented Jul 6, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant