Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding subnets taggings capability when creating a VPC #14

Merged
merged 5 commits into from
Oct 24, 2019

Conversation

tminussi
Copy link
Contributor

@tminussi tminussi commented Oct 22, 2019

Motivation

When creating Kubernetes (k8s) clusters in EKS, subnets tagging is mandatory. Currently, it's not possible to create such clusters using this VPC module.

Changes

This PR aims at enabling the tagging capability on subnets created by the VPC module

Usage

In order to tag the subnets, simply inject values for public_subnet_tags and private_subnet_tags

  public_subnet_tags = {
    "kubernetes.io/cluster/cluster-name" = "shared"
    "kubernetes.io/role/elb"                      = "1"
  }

  private_subnet_tags = {
    "kubernetes.io/cluster/cluster-name" = "shared"
    "kubernetes.io/role/internal-elb"             = "1"
  }

@mpas
Copy link
Contributor

mpas commented Oct 23, 2019

@tminussi Looks ok, but can you make a small note in the documentation to indicate why we have a separate public_subnet_tags and private_subnet_tags?

@tminussi
Copy link
Contributor Author

@mpas I have update both the README.md file as well as the examples under examples/

@mpas mpas merged commit 523b008 into philips-software:develop Oct 24, 2019
@tminussi tminussi deleted the feature/subnets-tagging branch October 24, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants