Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(runners): add support to disable default labels (Windows) #4261

Conversation

jgutierrezglez
Copy link
Contributor

@jgutierrezglez jgutierrezglez commented Nov 15, 2024

@@ Description

Adding support for no default labels on Windows, see #3491

@jgutierrezglez jgutierrezglez force-pushed the enable_default_labels_options_windows_fix branch from 02afa59 to 054189b Compare November 15, 2024 13:16
@npalm npalm self-requested a review November 15, 2024 15:16
@jgutierrezglez jgutierrezglez force-pushed the enable_default_labels_options_windows_fix branch from 054189b to 1e05df1 Compare November 18, 2024 05:49
@npalm
Copy link
Member

npalm commented Nov 19, 2024

on my back log to test.

@npalm npalm changed the title feat: Adding the possibility of removing the default labels (Windows fix) feat(runners): add support to disable default labels (Windows) Nov 19, 2024
@npalm npalm changed the title feat(runners): add support to disable default labels (Windows) feat(runners): add support to disable default labels (Windows) Nov 19, 2024
@jgutierrezglez jgutierrezglez force-pushed the enable_default_labels_options_windows_fix branch from 74cdaef to b9a8314 Compare November 19, 2024 13:17
@jgutierrezglez jgutierrezglez force-pushed the enable_default_labels_options_windows_fix branch from b9a8314 to 3122671 Compare November 19, 2024 13:24
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running test based on multi-runner windows example

Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

  • standard multi runner (windows)
  • standard multi runner disabled default labels (windows)
  • standard multi runner ephemeral disabled default labes (windows)
image

@npalm npalm merged commit ad9bcc4 into philips-labs:main Nov 19, 2024
42 checks passed
npalm pushed a commit that referenced this pull request Nov 19, 2024
🤖 I have created a release *beep* *boop*
---


##
[5.20.0](v5.19.0...v5.20.0)
(2024-11-19)


### Features

* **runners:** add support to disable default labels (Linux)
([#3491](#3491))
([772e1a5](772e1a5))
@jgutierrezglez
* **runners:** add support to disable default labels (Windows)
([#4261](#4261))
([ad9bcc4](ad9bcc4))
@jgutierrezglez


### Bug Fixes

* **lambda:** bump cross-spawn from 7.0.3 to 7.0.6 in /lambdas
([#4273](#4273))
([dcec236](dcec236))
* **lambda:** bump the aws group in /lambdas with 7 updates
([#4266](#4266))
([849549e](849549e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants