Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace deprecate aws_cloudwatch_event_rule.is_enabled, requires provide upgrade #3655

Merged
merged 20 commits into from
Dec 20, 2023
Merged

fix: Replace deprecate aws_cloudwatch_event_rule.is_enabled, requires provide upgrade #3655

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
2f00719
fix: deprecate aws_cloudwatch_event_rule.is_enabled
officel Dec 7, 2023
ec93d75
docs: auto update terraform docs
github-actions[bot] Dec 7, 2023
595382a
fix: use variable for aws_cloudwatch_event_rule.ami_housekeeper.state
officel Dec 8, 2023
725c9e6
docs: auto update terraform docs
github-actions[bot] Dec 8, 2023
f88cbb4
fix: use state for aws_cloudwatch_event_rule.syncer
officel Dec 8, 2023
a107d48
docs: auto update terraform docs
github-actions[bot] Dec 8, 2023
5c7a8d0
fix: rename variable cloudwatch_event_rule_state to state_event_rule_…
officel Dec 11, 2023
67ad8a9
fix: use ssm_housekeeper.state instead of ssm_housekeeper.enable
officel Dec 11, 2023
751101e
docs: auto update terraform docs
github-actions[bot] Dec 11, 2023
096b711
Merge branch 'main' into fix/deprecate_aws_cloudwatch_event_rule.is_e…
npalm Dec 16, 2023
a6e1903
fix: DEPRECATED enable_event_rule_binaries_syncer on top-level module
officel Dec 16, 2023
4cfbe39
docs: auto update terraform docs
github-actions[bot] Dec 16, 2023
9cfd6ed
Merge branch 'main' into fix/deprecate_aws_cloudwatch_event_rule.is_e…
npalm Dec 18, 2023
a151167
fix: DEPRECATED enable_event_rule_binaries_syncer in modules/multi-ru…
officel Dec 19, 2023
5efee46
docs: auto update terraform docs
github-actions[bot] Dec 19, 2023
0e02155
Merge branch 'main' into fix/deprecate_aws_cloudwatch_event_rule.is_e…
npalm Dec 19, 2023
2206895
fix: require aws provider version ~>5.27.0
officel Dec 19, 2023
91ce04c
docs: auto update terraform docs
github-actions[bot] Dec 20, 2023
3345c99
Merge branch 'main' into fix/deprecate_aws_cloudwatch_event_rule.is_e…
npalm Dec 20, 2023
b3a533e
fix: terraform init -upgrade for .terraform.lock.hcl
officel Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/ami-housekeeper/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ yarn run dist
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3.0 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | ~> 5.2 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | ~> 5.27.0 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | ~> 5.2 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | ~> 5.27.0 |

## Modules

Expand Down
2 changes: 1 addition & 1 deletion modules/ami-housekeeper/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ resource "aws_cloudwatch_event_rule" "ami_housekeeper" {
name = "${var.prefix}-ami-housekeeper-rule"
schedule_expression = var.lambda_schedule_expression
tags = var.tags
is_enabled = true
state = true
npalm marked this conversation as resolved.
Show resolved Hide resolved
}

resource "aws_cloudwatch_event_target" "ami_housekeeper" {
Expand Down
2 changes: 1 addition & 1 deletion modules/ami-housekeeper/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 5.2"
version = "~> 5.27.0"
}
}
}
4 changes: 2 additions & 2 deletions modules/runner-binaries-syncer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,13 @@ yarn run dist
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3.0 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | ~> 5.2 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | ~> 5.27.0 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | ~> 5.2 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | ~> 5.27.0 |

## Modules

Expand Down
2 changes: 1 addition & 1 deletion modules/runner-binaries-syncer/runner-binaries-syncer.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ resource "aws_cloudwatch_event_rule" "syncer" {
name = "${var.prefix}-syncer-rule"
schedule_expression = var.lambda_schedule_expression
tags = var.tags
is_enabled = var.enable_event_rule_binaries_syncer
state = var.enable_event_rule_binaries_syncer
}

resource "aws_cloudwatch_event_target" "syncer" {
Expand Down
2 changes: 1 addition & 1 deletion modules/runner-binaries-syncer/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 5.2"
version = "~> 5.27.0"
}
}
}
4 changes: 2 additions & 2 deletions modules/runners/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ yarn run dist
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3.0 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | ~> 5.2 |
| <a name="requirement_aws"></a> [aws](#requirement\_aws) | ~> 5.27.0 |

## Providers

| Name | Version |
|------|---------|
| <a name="provider_aws"></a> [aws](#provider\_aws) | ~> 5.2 |
| <a name="provider_aws"></a> [aws](#provider\_aws) | ~> 5.27.0 |

## Modules

Expand Down
2 changes: 1 addition & 1 deletion modules/runners/ssm-housekeeper.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ resource "aws_cloudwatch_event_rule" "ssm_housekeeper" {
name = "${var.prefix}-ssm-housekeeper"
schedule_expression = local.ssm_housekeeper.schedule_expression
tags = var.tags
is_enabled = local.ssm_housekeeper.enabled
state = local.ssm_housekeeper.enabled
}

resource "aws_cloudwatch_event_target" "ssm_housekeeper" {
Expand Down
2 changes: 1 addition & 1 deletion modules/runners/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 5.2"
version = "~> 5.27.0"
}
}
}