Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: misnamed variable create_service_linked_role -> create_service_linked_role_spot #736

Closed
boldandbusted opened this issue Apr 6, 2021 · 1 comment · Fixed by #750
Labels

Comments

@boldandbusted
Copy link
Contributor

Howdy. This line in README.md:

"To use terraform for creating the role, either add the following resource or let the module manage the the service linked role by setting create_service_linked_role to true."

should be:

To use terraform for creating the role, either add the following resource or let the module manage the the service linked role by setting create_service_linked_role_spot to true.

Cheers! This module rocks.

@npalm npalm added the good first issue Good for newcomers label Apr 13, 2021
forest-releaser bot pushed a commit that referenced this issue Jun 1, 2021
### [0.13.1](v0.13.0...v0.13.1) (2021-06-01)

### Bug Fixes

* .gitignore for 'secrets.auto.tfvars' ([38d7df0](38d7df0))
* Add some essential dependecies on ubuntu example ([0079d16](0079d16))
* fail to download wrong tag of lambda ([#840](#840)) ([1112ca8](1112ca8))
* increase runner sync lambda memory setting and upgrade npm dependencies ([#844](#844)) ([b9e36e9](b9e36e9))
* revert dependency updates on runner module ([#784](#784)) ([76cdbe3](76cdbe3))
* ubuntu example runner_log_files variable ([5b3fc5b](5b3fc5b))
* ubuntu example to log syslog instead of messages ([#785](#785)) ([fb3e5d2](fb3e5d2))
* Update ubuntu example with assume_role comment ([2478daf](2478daf))
* upgrade runner module to support upgrade octokit auth-app ([#786](#786)) ([e110318](e110318))
* **docs:** fix variable name create_service_linked_role_spot in readme ([#750](#750)) ([42b0427](42b0427)), closes [#736](#736)
@forest-releaser
Copy link
Contributor

🎉 This issue has been resolved in version 0.13.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants