-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(runners): add support to disable default labels (Windows) #4261
Merged
npalm
merged 1 commit into
philips-labs:main
from
jgutierrezglez:enable_default_labels_options_windows_fix
Nov 19, 2024
Merged
feat(runners): add support to disable default labels (Windows) #4261
npalm
merged 1 commit into
philips-labs:main
from
jgutierrezglez:enable_default_labels_options_windows_fix
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgutierrezglez
force-pushed
the
enable_default_labels_options_windows_fix
branch
from
November 15, 2024 13:16
02afa59
to
054189b
Compare
jgutierrezglez
force-pushed
the
enable_default_labels_options_windows_fix
branch
from
November 18, 2024 05:49
054189b
to
1e05df1
Compare
on my back log to test. |
npalm
changed the title
feat: Adding the possibility of removing the default labels (Windows fix)
feat(runners): add support to disable default labels (Windows)
Nov 19, 2024
npalm
changed the title
feat(runners): add support to disable default labels (Windows)
feat(runners): add support to disable default labels (Windows)
Nov 19, 2024
jgutierrezglez
force-pushed
the
enable_default_labels_options_windows_fix
branch
from
November 19, 2024 13:17
74cdaef
to
b9a8314
Compare
jgutierrezglez
force-pushed
the
enable_default_labels_options_windows_fix
branch
from
November 19, 2024 13:24
b9a8314
to
3122671
Compare
npalm
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running test based on multi-runner windows example
npalm
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npalm
pushed a commit
that referenced
this pull request
Nov 19, 2024
🤖 I have created a release *beep* *boop* --- ## [5.20.0](v5.19.0...v5.20.0) (2024-11-19) ### Features * **runners:** add support to disable default labels (Linux) ([#3491](#3491)) ([772e1a5](772e1a5)) @jgutierrezglez * **runners:** add support to disable default labels (Windows) ([#4261](#4261)) ([ad9bcc4](ad9bcc4)) @jgutierrezglez ### Bug Fixes * **lambda:** bump cross-spawn from 7.0.3 to 7.0.6 in /lambdas ([#4273](#4273)) ([dcec236](dcec236)) * **lambda:** bump the aws group in /lambdas with 7 updates ([#4266](#4266)) ([849549e](849549e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@@ Description
Adding support for no default labels on Windows, see #3491