fix: remove export from install script. (#1538)

* fix: remove export from install script. * Add log line to the run as root export
philips-labs · Dec 21, 2021 · d32ca1b · d32ca1b
1 parent 1cd9cd3
commit d32ca1b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/modules/runners/templates/install-runner.sh b/modules/runners/templates/install-runner.sh
@@ -37,9 +37,6 @@ rm -rf $file_name
 
 ${ARM_PATCH}
 
-echo "export RUNNER_ALLOW_RUNASROOT=1"
-export RUNNER_ALLOW_RUNASROOT=1
-
 os_id=$(awk -F= '/^ID/{print $2}' /etc/os-release)
 if [[ "$os_id" =~ ^ubuntu.* ]]; then
     echo "Installing dependencies"

diff --git a/modules/runners/templates/start-runner.sh b/modules/runners/templates/start-runner.sh
@@ -50,12 +50,13 @@ echo "Delete GH Runner token from AWS SSM"
 aws ssm delete-parameter --name "$environment"-"$instance_id" --region "$region"
 
 if [ -z "$run_as" ]; then
-    echo "No user specified, using default ec2-user account"
-    run_as="ec2-user"
+  echo "No user specified, using default ec2-user account"
+  run_as="ec2-user"
 fi
 
 if [[ "$run_as" == "root" ]]; then
-    export RUNNER_ALLOW_RUNASROOT=1
+  echo "run_as is set to root - export RUNNER_ALLOW_RUNASROOT=1"
+  export RUNNER_ALLOW_RUNASROOT=1
 fi
 
 echo "Configure GH Runner as user $run_as"