Add missing await

philips-labs · Dec 7, 2021 · 21bd350 · 21bd350
1 parent ba504f8
commit 21bd350
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/src/lambda.test.ts b/modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/src/lambda.test.ts
@@ -12,13 +12,13 @@ describe('Test scale up lambda wrapper.', () => {
         resolve();
       });
     });
-    await expect(handler({}, {}, {})).resolves;
+    await expect(handler({}, {})).resolves;
   });
 
   it('Scale without error should resolve2 . ', async () => {
     const mock = mocked(sync);
     mock.mockRejectedValue(new Error(''));
 
-    await expect(handler({}, {}, {})).resolves;
+    await expect(handler({}, {})).resolves;
   });
 });
diff --git a/modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/src/lambda.ts b/modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/src/lambda.ts
@@ -2,15 +2,13 @@ import { sync } from './syncer/syncer';
 import { logger } from './syncer/logger';
 
 // eslint-disable-next-line
-export async function handler(event: any, context: any, callback: any): Promise<void> {
+export async function handler(event: any, context: any): Promise<void> {
   logger.setSettings({ requestId: context.awsRequestId });
   logger.debug(JSON.stringify(event));
 
   try {
     await sync();
-    callback(null);
   } catch (e) {
     logger.warn('Ignoring error:', e);
-    callback(e);
   }
 }
diff --git a/modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/src/syncer/syncer.ts b/modules/runner-binaries-syncer/lambdas/runner-binaries-syncer/src/syncer/syncer.ts
@@ -125,7 +125,7 @@ export async function sync(): Promise<void> {
   const currentVersion = await getCachedVersion(s3, cacheObject);
   logger.debug('latest: ' + currentVersion);
   if (currentVersion === undefined || currentVersion != actionRunnerReleaseAsset.name) {
-    uploadToS3(s3, cacheObject, actionRunnerReleaseAsset);
+    await uploadToS3(s3, cacheObject, actionRunnerReleaseAsset);
   } else {
     logger.debug('Distribution is up-to-date, no action.');
   }