-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make k8s keychain vs default keychain configurable #130
Conversation
0bab1c8
to
c658be7
Compare
Codecov Report
@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 77.92% 77.54% -0.39%
==========================================
Files 15 15
Lines 607 610 +3
==========================================
Hits 473 473
- Misses 95 97 +2
- Partials 39 40 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I have been testing this in a private registry, but unfortunately, I don't think this is working yet. |
e4f49b9
to
89e7674
Compare
Unfortunately, I think this is not yet resolved, internal testing shows that it is still an issue. This can either be in my workflow (am I missing some step), or in slsa action. On the other hand, docker-ci-scripts is working. This makes me think the workflow is wrong. |
89e7674
to
10711af
Compare
The rootcause of our problem is that we are running the We have 2 option here.
|
e6280d8
to
05ae2f5
Compare
Please note, once this PR gets merged, our draft releases will fail. Due to different asset urls for draft releases. Not sure how to compute those. |
9645bcd
to
3cee7d3
Compare
Signed-off-by: Marco Franssen <[email protected]>
This to resolve workflows that require docker login Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
Signed-off-by: Marco Franssen <[email protected]>
Co-authored-by: Brend Smits <[email protected]> Signed-off-by: Marco Franssen <[email protected]>
c9965bc
to
20993bb
Compare
Signed-off-by: Marco Franssen <[email protected]>
This is something we only require for testing our releases Signed-off-by: Marco Franssen <[email protected]>
https://github.com/philips-labs/slsa-provenance-action/actions/runs/1840388657 It now also works for draft releases. |
20993bb
to
419b873
Compare
https://github.com/philips-labs/slsa-provenance-action/releases/tag/v0.7.0-rc
https://github.com/philips-labs/slsa-provenance-action/actions/runs/1824661573