Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use commit messages that contain apostrophes #116

Closed
davidsbond opened this issue Jan 10, 2022 · 2 comments · Fixed by #117
Closed

Cannot use commit messages that contain apostrophes #116

davidsbond opened this issue Jan 10, 2022 · 2 comments · Fixed by #117
Assignees
@JeroenKnoops
Labels
bug Something isn't working

Comments

@davidsbond
Copy link

Hey folks, thanks for creating this useful action.

I've found an issue when generating the provenance that if a commit contains an apostrophe it fails to encode the github context correctly:

/home/runner/work/_temp/23f196b1-6f36-4322-a6e0-0596e1da9544.sh: line 229: unexpected EOF while looking for matching `''

This appears to happen in this part of the action:

https://github.com/philips-labs/slsa-provenance-action/blob/main/action.yaml#L33
@Brend-Smits Brend-Smits added the bug Something isn't working label Jan 10, 2022
@JeroenKnoops JeroenKnoops self-assigned this Jan 11, 2022
@JeroenKnoops
Copy link
Member

Debugging in separate project: https://github.com/JeroenKnoops/encode-quote-in-github-context

@davidsbond
Copy link
Author

davidsbond commented Jan 11, 2022 •
edited
Loading

As a suggestion, instead of using echo here perhaps the JSON-encoded context could be written to a temporary file, then you can just cat it into base64 without worrying about substitution and quotes etc?

JeroenKnoops added a commit that referenced this issue Jan 11, 2022
@JeroenKnoops
Use tmp file to avoid problems with single quotes
d16c19b 
Closes #116

Signed-off-by: Jeroen Knoops <[email protected]>
@JeroenKnoops JeroenKnoops mentioned this issue Jan 11, 2022
Merged
JeroenKnoops added a commit that referenced this issue Jan 14, 2022
@JeroenKnoops
Pass json as environment variables
a16ebc9 
Closes #116

Signed-off-by: Jeroen Knoops <[email protected]>
@marcofranssen marcofranssen mentioned this issue Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JeroenKnoops JeroenKnoops

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use environment variables to pass context jsons philips-labs/slsa-provenance-action
3 participants
@JeroenKnoops @davidsbond @Brend-Smits