-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@types/ramda
is missing, causing type errors
#32
Comments
Hey, thanks @JReinhold. I've moved Have republished on NPM as v2.4.2 Please sing out if that does or doesn't resolve this. ref → PR |
* update refs * Move "@types/ramda" to {dependencies} Issue #32
Thanks @philcockfield. It seems like the problem has now "moved on" to I don't think any of the other |
It appears that
v2.4.1
introduces a type error that is caught in the Storybook CI here, for a PR that upgrades to said version: https://app.circleci.com/pipelines/github/storybookjs/storybook/53837/workflows/8ef6bf7f-46c8-4605-8fa2-f804ed46350c/jobs/552019It looks like you're exporting types from
ramda
, but@types/ramda
is only set as adevDependency
, so it's not present to users (like us) that depends on your library.This is what's exported: https://www.npmjs.com/package/file-system-cache?activeTab=code
My suggestion would be to bundle with
tsup
, as that bundles in the types as well. But that might be a bigger task, so moving@types/ramda
to adependency
is also an option.This problem only occurs if
skipLibCheck
intsconfig
isfalse
, which is the default.I'm unsure why this problem was only introduced in
2.4.1
, and not before.The text was updated successfully, but these errors were encountered: