Fix Firefox link hints. #2960
Merged
Fix Firefox link hints. #2960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes philc#2958 (probably). This appears to be correct for target "_blank" (or not) and modifiers (or not). That's four cases. It will be *incorrect* if there is a click listener on a target "_blank" link. Some conditions are tested to try to prevent that from happening. This only affects Firefox. Chrome is unaffected.
|
Tried it locally, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2958 (probably).
This appears to be correct for target "_blank" (or not) and modifiers (or not). That's four cases.
It will be incorrect if there is a click listener on a target "_blank" link. Some conditions are tested to try to prevent this from happening.
This only affects Firefox. Chrome is unaffected.