Do not open tab for target "_blank".

Fixes #2860. That issue reports that, when the target is "_blank", Firefox/Vimium ends up opening two tabs.
philc · Dec 16, 2017 · 1b23f70 · 1b23f70
1 parent b6a0bd0
commit 1b23f70
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/dom_utils.coffee b/lib/dom_utils.coffee
@@ -250,7 +250,7 @@ DomUtils =
     eventSequence = ["mouseover", "mousedown", "mouseup", "click"]
     for event in eventSequence
       defaultActionShouldTrigger = @simulateMouseEvent event, element, modifiers
-      if event == "click" and defaultActionShouldTrigger and Utils.isFirefox()
+      if event == "click" and defaultActionShouldTrigger and Utils.isFirefox() and element.target != "_blank"
         # Firefox doesn't (currently) trigger the default action for modified keys.
         DomUtils.simulateClickDefaultAction element, modifiers
       defaultActionShouldTrigger # return the values returned by each @simulateMouseEvent call.