Skip to content

Commit

Permalink
hook up unstable_enableSyncVoidMethods to ReactFeatureFlags (facebook…
Browse files Browse the repository at this point in the history
…#39988)

Summary:
Pull Request resolved: facebook#39988

Changelog: [Internal]

in this pr, we integrate the sync void configuration with our feature flag infra

Reviewed By: luluwu2032

Differential Revision: D50030743

fbshipit-source-id: 6f47be3c46572d7d5ebed92f20b798f98b50bd14
  • Loading branch information
philIip authored and facebook-github-bot committed Oct 9, 2023
1 parent 5267f85 commit a1038d7
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ interface ModuleProvider {
mShouldEnableLegacyModuleInterop
&& ReactFeatureFlags.unstable_useTurboModuleInteropForAllTurboModules;

private final boolean mEnableTurboModuleSyncVoidMethods =
ReactFeatureFlags.unstable_enableTurboModuleSyncVoidMethods;

protected ReactPackageTurboModuleManagerDelegate() {
super();
}
Expand Down Expand Up @@ -140,6 +143,10 @@ public boolean unstable_shouldRouteTurboModulesThroughLegacyModuleInterop() {
return mShouldRouteTurboModulesThroughLegacyModuleInterop;
}

public boolean unstable_enableSyncVoidMethods() {
return mEnableTurboModuleSyncVoidMethods;
}

@Nullable
@Override
public TurboModule getModule(String moduleName) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ public class ReactFeatureFlags {
*/
public static volatile boolean unstable_useTurboModuleInteropForAllTurboModules = false;

public static volatile boolean unstable_enableTurboModuleSyncVoidMethods = false;

/**
* Should this application use the new (Fabric) Renderer? If yes, all rendering in this app will
* use Fabric instead of the legacy renderer.
Expand Down

0 comments on commit a1038d7

Please sign in to comment.