Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Use separate file for the cache, reduce size #25

Closed
Moonbase59 opened this issue Jul 22, 2021 · 2 comments
Closed

Suggestion: Use separate file for the cache, reduce size #25

Moonbase59 opened this issue Jul 22, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@Moonbase59
Copy link

Moonbase59 commented Jul 22, 2021

Just a suggestion: If one uses definition caching, the cache grows rapidly, even after the fix not to double-cache. I don’t think it’s wise to keep all this together with the plugin settings in data.json.

Instead, I propose to use a separate cache.json, which would also make the deleting of the cache much easier.

The data file currently uses a lot of space because it is "pretty" JSON. I don’t think users will ever manually edit it, so I also propose to use something like JSON.stringify() to make it more compact and faster loading.

How do you feel about that?

@Moonbase59 Moonbase59 changed the title Suggestion: Use a separate file for the cached definitions Suggestion: Use separate file for the cache, reduce size Jul 22, 2021
@phibr0
Copy link
Owner

phibr0 commented Jul 22, 2021

That's a good improvement. I will have to look into how this would be handled on mobile though

@phibr0 phibr0 added the enhancement New feature or request label Jul 24, 2021
phibr0 added a commit that referenced this issue Jul 24, 2021
@phibr0 phibr0 closed this as completed Jul 24, 2021
@Moonbase59
Copy link
Author

Moonbase59 commented Jul 24, 2021

Man, you’re progressing at a fast pace! 😍 👍 Thanks for your time and committment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants