2.10.1: Dictionary View doesn’t show

[Moonbase59]

When trying to open the dictionary side pane, I get:

app.js:1 Failed to open view TypeError: _a.getElementById is not a function
    at append_styles (eval at <anonymous> (app.js:1), <anonymous>:529:75)
    at add_css$1 (eval at <anonymous> (app.js:1), <anonymous>:2284:2)
    at init (eval at <anonymous> (app.js:1), <anonymous>:1003:22)
    at new DictionaryView$1 (eval at <anonymous> (app.js:1), <anonymous>:2923:3)
    at DictionaryView.eval (eval at <anonymous> (app.js:1), <anonymous>:3052:26)
    at Generator.next (<anonymous>)
    at eval (eval at <anonymous> (app.js:1), <anonymous>:31:71)
    at new Promise (<anonymous>)
    at __awaiter (eval at <anonymous> (app.js:1), <anonymous>:27:12)
    at DictionaryView.onOpen (eval at <anonymous> (app.js:1), <anonymous>:3051:16)
(anonymous) @ app.js:1

[phibr0]

I am not entirely sure why that happened but it seems to be fixed now

[phibr0]

No seems like its not fixed, it just doesnt happen consistently.

[Moonbase59]

Can you reproduce? Anything I could do or test?

[phibr0]

Yes, but not consistently

[Moonbase59]

Too bad. I can’t even make it appear on two different machines. Tried restarting Obsidian, closing/reopening the side pane, deleting the cache, etc.

Btw, it shows version 2.10.1 and wants to upgrade to 2.10.2 which fails.

What’s better for testing?

• revert back to 2.10.0, or
• stick at 2.10.1 and look through your commits?

[Moonbase59]

Did a quick check, comparing 2.10.0 → 2.10.2 (Compare) but nothing obvious.

Except maybe b251756—sure you committed everything? "Fix View not loading" is just a version number change in manifest.json?

[phibr0]

I fixed the manifest so it doesn't want to update anymore. Not really sure what caused it but I will look through my commits again.

Except maybe b251756—sure you committed everything? "Fix View not loading" is just a version number change in manifest.json?

I guess it didn't happen once and I just thought "oh nice, guess I fixed it" - I didn't even realize I didn't change anything

[phibr0]

I tested every single commit I made and every build had this error, I even tried using the Commit where I first introduced the Caching Feature using git checkout 83b42344d01e666333fb8643a9671f2c156bc58d.

Even this Build has the same Error now. I also deleted the untracked data.json, which didnt help either.

---

I just went back to master and its working again as it should.. This is so weird

[Moonbase59]

That’s really weird.

[phibr0]

sveltejs/svelte#6567

Same Issue that is happening with this Plugin. When downgraded to an older svelte version it works fine.

[Moonbase59]

Darn, so a framework issue. Then again, since svelte is kinda compiler and not a module, it might be worth downgrading until that’s fixed, so at least you could release new versions. What do you think?

[phibr0]

Yeah already did that, its not a Problem and I actually didn't even mean to upgrade it. I just ran npm upgrade to get Obsidians new request API, but the command of course upgrades every package. I need to be more careful with stuff like that.

Since the node_modules aren't tracked by git and in the package.json I set the svelte version to x.x or higher npm didnt care about the higher Svelte Version even when i went back to older commits, which is why the Error persisted with older commits.

[phibr0]

Seems like its still happening, can't even reproduce my fix from a few hours ago

[phibr0]

Seems like this Issue is finally fixed as of Svelte v3.40.3 (sveltejs/svelte#6567)

Closing this now

[Moonbase59]

Confirm working fine with version 2.13.2.