Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn down the volume on slider clicks. #474

Closed
samreid opened this issue Feb 8, 2020 · 12 comments
Closed

Turn down the volume on slider clicks. #474

samreid opened this issue Feb 8, 2020 · 12 comments

Comments

@samreid
Copy link
Member

samreid commented Feb 8, 2020

From #465 and related to #473, the slider clicks are too loud.

AP: The slider ratchet sounds are irritating for me.
AR: It's appropriate for John Travoltage, but not fitting for these sliders.
EM: It's currently very loud.
AP: Maybe it will be better when volume balanced.

EM: We wanted something "neutral" here, so it won't catch your attention too much.

@samreid samreid self-assigned this Feb 8, 2020
@samreid
Copy link
Member Author

samreid commented Feb 13, 2020

@Ashton-Morris was this addressed during #473 ?

@emily-phet
Copy link

@samreid @Ashton-Morris I think in this version - https://phet-dev.colorado.edu/html/waves-intro/1.1.0-dev.14/phet/waves-intro_en_phet.html all of the common UI sounds can be turned down. At least from my setup (speakers on my laptop), the clicker sounds, pick up/drop tool sounds, etc. are all louder than the water drop sound, graph tool sound, etc. It needs to be reversed...you should barely notice the common UI sounds when volume is at moderate.

I believe these common UI sounds may be categorized together in the code, and perhaps their loudness can be tuned as a whole set (not needing to be done individually).

@samreid
Copy link
Member Author

samreid commented Feb 20, 2020

I categorized appropriate sounds as user-interface and adjusted the volume. @emily-phet can you please review on phettest?

@arouinfar
Copy link
Contributor

@samreid I think master's definitely an improvement!

@arouinfar arouinfar removed their assignment Feb 20, 2020
@arouinfar
Copy link
Contributor

@samreid I think you may have inadvertently classified the wave detector as a user-interface element. It sounds a bit quieter in master compared to dev.14.

@samreid
Copy link
Member Author

samreid commented Feb 20, 2020

@kathy-phet said: One click sounds a reasonable volume, but since these come in bursts, they should be reduced further.

@samreid asked: What number should I aim for?
@kathy-phet: Let's check.

@samreid
Copy link
Member Author

samreid commented Mar 6, 2020

I cut it in half in the commit, but this cannot be reviewed until #483 is addressed.

@samreid
Copy link
Member Author

samreid commented Mar 6, 2020

OK #483 has a proposed fix and is up for review. @kathy-phet or @arouinfar can you please check the slider click volume? Also, please be aware the sound effect itself changed as part of #484. Marking high priority in case this should be done before interviews.

@kathy-phet
Copy link

kathy-phet commented Mar 6, 2020

Seems like a "softer" less "cheerpy" sound to me. A bit scratchy - but not sure that can be avoided. @ariel-phet should weigh in here.

@arouinfar
Copy link
Contributor

@samreid I like the updated slider sound and its volume in master.

@arouinfar arouinfar removed their assignment Mar 6, 2020
@ariel-phet
Copy link

Definitely an improvement!

@ariel-phet ariel-phet removed their assignment Mar 16, 2020
@emily-phet
Copy link

Closing this issue, and continuing slider UI sound-related discussion in #484.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants