-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn down the volume on slider clicks. #474
Comments
@Ashton-Morris was this addressed during #473 ? |
@samreid @Ashton-Morris I think in this version - https://phet-dev.colorado.edu/html/waves-intro/1.1.0-dev.14/phet/waves-intro_en_phet.html all of the common UI sounds can be turned down. At least from my setup (speakers on my laptop), the clicker sounds, pick up/drop tool sounds, etc. are all louder than the water drop sound, graph tool sound, etc. It needs to be reversed...you should barely notice the common UI sounds when volume is at moderate. I believe these common UI sounds may be categorized together in the code, and perhaps their loudness can be tuned as a whole set (not needing to be done individually). |
I categorized appropriate sounds as |
@samreid I think master's definitely an improvement! |
@samreid I think you may have inadvertently classified the wave detector as a |
@kathy-phet said: One click sounds a reasonable volume, but since these come in bursts, they should be reduced further. @samreid asked: What number should I aim for? |
I cut it in half in the commit, but this cannot be reviewed until #483 is addressed. |
OK #483 has a proposed fix and is up for review. @kathy-phet or @arouinfar can you please check the slider click volume? Also, please be aware the sound effect itself changed as part of #484. Marking high priority in case this should be done before interviews. |
Seems like a "softer" less "cheerpy" sound to me. A bit scratchy - but not sure that can be avoided. @ariel-phet should weigh in here. |
@samreid I like the updated slider sound and its volume in master. |
Definitely an improvement! |
Closing this issue, and continuing slider UI sound-related discussion in #484. |
From #465 and related to #473, the slider clicks are too loud.
AP: The slider ratchet sounds are irritating for me.
AR: It's appropriate for John Travoltage, but not fitting for these sliders.
EM: It's currently very loud.
AP: Maybe it will be better when volume balanced.
EM: We wanted something "neutral" here, so it won't catch your attention too much.
The text was updated successfully, but these errors were encountered: