Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The theory rays don't reach the right side of the wave area. #296

Closed
samreid opened this issue Jan 1, 2019 · 5 comments
Closed

The theory rays don't reach the right side of the wave area. #296

samreid opened this issue Jan 1, 2019 · 5 comments

Comments

@samreid
Copy link
Member

samreid commented Jan 1, 2019

Discovered in #289, the rays don't all reach the right side of the wave area:

image

Is that by design, or should the rays be lengthened?

@arouinfar
Copy link
Contributor

@samreid can you extend the radius of the rays? It looks a bit odd that some of the rays do not reach all the way to the screen.

@arouinfar arouinfar assigned samreid and unassigned arouinfar Jan 1, 2019
samreid added a commit that referenced this issue Jan 1, 2019
@samreid
Copy link
Member Author

samreid commented Jan 1, 2019

I made the rays longer, @arouinfar can you please review on phettest? Close if all is well.

@arouinfar
Copy link
Contributor

@samreid I just realized the issue -- the source point should be at the barrier. It looks like ?theory is originating from the lattice origin for the previous screens.

@arouinfar arouinfar assigned samreid and unassigned arouinfar Jan 2, 2019
@samreid
Copy link
Member Author

samreid commented Jan 2, 2019

Thanks @arouinfar, a bug was introduced when working on the barrier coordinate frame. Should be repaired now, please review on phettest and close if all is well.

@samreid samreid assigned arouinfar and unassigned samreid Jan 2, 2019
@arouinfar
Copy link
Contributor

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants