-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nonstandard names for model classes #271
Comments
Closed
samreid
added a commit
that referenced
this issue
Dec 20, 2018
samreid
added a commit
to phetsims/circuit-construction-kit-black-box-study
that referenced
this issue
Dec 20, 2018
samreid
added a commit
to phetsims/circuit-construction-kit-basics
that referenced
this issue
Dec 20, 2018
samreid
added a commit
to phetsims/circuit-construction-kit-dc
that referenced
this issue
Dec 20, 2018
Proposed fixes pushed for Wave Interference and Circuit Construction Kit, ready for review. |
👍 Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to code review #259.
The screen names in this sim are Waves, Interference, Slits, and Diffraction. So based on other sims that I've reviewed, I'd expect to find top-level model classes
WavesModel
,InterferenceModel
,SlitsModel
, andDiffractionModel
respectively.DiffractionModel
is as expected. But the others areWavesScreenModel
,InterferenceScreenModel
,SlitsScreenModel
.Searching for "ScreenModel" shows that this naming scheme is also used in circuit-construction-kit-dc and circuit-construction-kit-black-box-study. The naming convention used in all other sims has served us well, and I see no benefit to deviating or changing. So unless there's a really good reason to spend time in a dev meeting discussing a different naming convention, I recommend to rename the model classes in this sim, circuit-construction-kit-dc, and circuit-construction-kit-black-box-study
The text was updated successfully, but these errors were encountered: